Remove dead RHEL 7/8 ansible code paths and orphaned nutanix cloud-init files#2001
Remove dead RHEL 7/8 ansible code paths and orphaned nutanix cloud-init files#2001mboersma wants to merge 1 commit into
Conversation
…it files
The repo no longer builds RHEL/CentOS 7 or 8 (only -9 variants are in
the Makefile and README matrix), so several conditional tasks and a
pair of orphaned Nutanix cloud-init templates are unreachable:
- roles/providers/tasks/main.yml: 'Set cloudinit feature flags for
redhat 8' (gated on RHEL 8).
- roles/sysprep/tasks/main.yml: 'not (RedHat and major_version <= 7)'
guard around journalctl rotate.
- packer/nutanix/linux/cloud-init/{rhel,rockylinux}/8/user-data.tmpl:
no rhel-8.json or rockylinux-8.json consumes them.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/S
|
@mboersma: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Hello @mboersma , we have RHEL8 target again, did i miss something ? |
3 participants
Change description
Cleanup of dead code and orphaned files for RHEL/CentOS 7 and 8 paths that are no longer build targets. The Makefile and README matrix have only
*-9variants for RHEL/CentOS/Rocky/AlmaLinux.Removes:
roles/providers/tasks/main.yml: theSet cloudinit feature flags for redhat 8task (gated ondistribution_major_version == "8").roles/sysprep/tasks/main.yml: the<= 7guard around theRotate journalctltask (always-true now).packer/nutanix/linux/cloud-init/{rhel,rockylinux}/8/user-data.tmpl: orphaned — there's norhel-8.jsonorrockylinux-8.jsoninpacker/nutanix/that would consume them.make lintpasses cleanly.Related issues
rh8_rpmsblocks inpacker/goss/goss-vars.yaml.Additional context
No behavior change for any currently-built distro.